Improve printing of symmetric matrices when used in constraints #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3768 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 44 44
Lines 5879 5885 +6
=======================================
+ Hits 5784 5790 +6
Misses 95 95 ☔ View full report in Codecov by Sentry. |
|
What about some other options: julia> c = @constraint(model, x == 0)
[x[1,1] x[1,2] x[1,3] x[1,4]
↙ x[2,2] x[2,3] x[2,4]
↙ ↙ x[3,3] x[3,4]
↙ ↙ ↙ x[4,4]] ∈ Zeros()
julia> c = @constraint(model, x == 0)
[x[1,1] x[1,2] x[1,3] x[1,4]
∘ x[2,2] x[2,3] x[2,4]
∘ ∘ x[3,3] x[3,4]
∘ ∘ ∘ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⋰ x[2,2] x[2,3] x[2,4]
⋰ ⋰ x[3,3] x[3,4]
⋰ ⋰ ⋰ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⤯ x[2,2] x[2,3] x[2,4]
⤯ ⤯ x[3,3] x[3,4]
⤯ ⤯ ⤯ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⦸ x[2,2] x[2,3] x[2,4]
⦸ ⦸ x[3,3] x[3,4]
⦸ ⦸ ⦸ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⇗ x[2,2] x[2,3] x[2,4]
⇗ ⇗ x[3,3] x[3,4]
⇗ ⇗ ⇗ x[4,4]] ∈ Zeros()
julia> c
[x[1,1] x[1,2] x[1,3] x[1,4]
⋯ x[2,2] x[2,3] x[2,4]
⋯ ⋯ x[3,3] x[3,4]
⋯ ⋯ ⋯ x[4,4]] ∈ Zeros() |
odow
commented
Jun 5, 2024
|
Use of It hints at "something else is here" and avoids confusion with |
|
Merging because I think this is a win, and it is needed for #3766 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3764
So there is an argument for this, especially if we merge #3766, because it will help distinguish when JuMP exploits symmetry.